Today I still tried to improve code quality of application. I double-checked what I had done previously to be sure I didn’t introduce some typo. I’ve been working on that when I got message from testers that they experienced some strange behaviour with the application. It just showed them blank screen when they had tried enter given page. I made quit investigation and found a problem.

The worst thing was that it happened because of automatically merge – two additional lines were added where the same lines already were there but surrounded with if () to protect against NullPointerException. It was stupid mistake and any test didn’t check such piece of code against null value. I will have to add some tests and check more carefully in the future what was merged during project update. I’m using IntelliJ IDEA and there is fancy window with update status, see below:

update-info

After quick fix and deployment to test environment I was able to came back to refactoring. I’ve been digging around trying to find places where the code can be improved.

In mean time I’ve got request to correct some mistakes on the print template I had made few days ago. It took me about one hour and once again I was able follow with application refactoring.